feat: Implement comprehensive theme system with harmonized color palette #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Theme struct with hex color support for all UI components - Implement environment-based auto theme detection - Replace hardcoded colors with theme-aware color system - Add predefined themes (dark/light) with proper contrast - Support custom user-defined themes in config file - Fix Recent History timestamp color display issue - Maintain backward compatibility with existing color settings - Remove deprecated ColorScheme struct and legacy code Resolves light mode visibility issues in Host List and Host Details panels.
- Add theme partial override functionality for predefined themes - Implement custom theme validation requiring complete definitions - Replace hardcoded GetThemeList with dynamic generation from PredefinedThemes - Add xoria256, monokai, nord, gruvbox themes to predefined collection - Introduce mergeThemes mechanism for YAML configuration loading - Remove auto theme detection and simplify default to 'dark' - Add comprehensive test coverage for theme validation and merging
- Remove hardcoded colors from TUI components - Apply theme colors consistently across all panels (background, borders, text) - Add 't' key binding for theme cycling in interactive mode - Enable mouse support in TUI application - Update help text to include theme cycling shortcut - Improve color consistency in table headers and cells
- Fix FormatHostDetail function calls to include Theme parameter in tests - Update NewHostListPanel test calls to include shared.Config parameter - Update theme list expectations in tests to match current predefined themes - Replace hardcoded color expectations with theme-based hex color codes - Ensure all tests pass with new theme architecture
- Change dark theme accent from #00ffff to #00afd7 (256-color code 038) - Update corresponding test expectations for new accent color - Provides a more refined cyan tone for accent elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features Added
Theme System Architecture
Color Palette Improvements
#00ff00→#5FFF87(harmonious green)#ff0000→#FF5F87(harmonious red-pink)#00ffff→#5FAFFF(softer blue, 256-color compatible)Configuration Support
Technical Implementation
Configstruct with YAML unmarshalingTest Plan